Remove fees - rounding when removing fees is not yet updated to use new rounding rules

Description

This issue was identified while examining source code. So as of the time of
this filing we don't have a UI based repro to report.

The code to remove fees was found to still be invoking old application logic for
rounding. The code needs to be changed to use the new rounding rules introduced
with the refactoring of financial calculation code.

Environment

Platform: All, OS: Windows XP

Activity

Show:
Jeff Brewster
May 28, 2008, 9:22 PM

Target v1.1 per triage meeting.

emilytucker
June 2, 2008, 11:27 PM

Van/Beth-- sorry to do this when both of you were out-- but I think this is an
issue we can triage for v1.1. I think the scenario of removing fees is rare
and isn't a primary use case we need to support. Can be an immediate fix after
launch.

If we do have spare cycles-- we might want to re-evaluate getting this into
v1.1.

Kay Chau
May 13, 2010, 5:24 PM

John can you see if this is still true?

johnwoodlock
May 18, 2010, 12:31 AM

I talked to Van about this.

So, Van went and checked through the loan code. He determined that the current code was now using the correct 'V2' rounding method / algorithm.

The only change made was to remove the method 'applyRounding' (which was delegating to the correct rounding method 'applyRounding_v2' and call the '_v2' method directly. This was just for clarity. The '_v2' naming can go at sometime in the future but not urgent.

Assignee

johnwoodlock

Reporter

Van Mittal-Henkle

Labels

None

URL

None

Story Points

0

Team

Core

Scheduled For

Release

Epic

None

Notify

None

productboard URL

None

Man Day Estimate

None

Components

Fix versions

Affects versions

Priority

Critical
Configure