Loan officer field is not required for Groups if Centers are turned off

Description

KMBI is not using centers, but instead just clients and Groups. When creating the group, the loan officer field is not marked as required and allows the user to create the group WITHOUT a loan officer.

REPRO:
Use a system with centers turned off
1. Select Create new group
2. Enter in all information but skip selecting a loan officer - Note, loan officer field is not marked as required but Recruiting officer is
3. Click on Preview and then Submit for Approval

EXPECTED:
Mifos shows that the loan officer is a required field and before continuing, throws an error that the loan officer needs to be set

ACTUAL:
Mifos allows group to be created without a loan officer being assigned

Workaround - User's can edit the group to fix the loan officer issue, but this could be troublesome for some MFI's that don't want to give the data entry people the right to edit group, only creating.

Environment

None

Activity

Show:
Mifos Hudson Jira Plugin User
February 10, 2011, 5:16 PM

Integrated in

head-f-release #56

Piotr Bogacz : c0e07089dd92d094f2d6683b017cd0811831798b
Files :

  • application/src/main/java/org/mifos/customers/group/struts/action/GroupCustAction.java

  • application/src/main/webapp/pages/application/group/jsp/creategroup.jsp

  • application/src/main/java/org/mifos/customers/group/struts/actionforms/GroupCustActionForm.java

  • appdomain/src/main/java/org/mifos/application/util/helpers/Methods.java

  • application/src/main/webapp/WEB-INF/struts-config.xml

Lukasz Chudy
February 11, 2011, 11:39 AM

Verified on 11.02.2011
Validation is now working properly also when 'Meeting schedule' is set.

Commit Identifier: a438206acdb3e861cd429cf435b5d76952dd3901
Build Number: hudson-head-f-release-59

Mifos Hudson Jira Plugin User
February 16, 2011, 8:33 AM

Integrated in

head-master #2886

Revert "MIFOS-3498"

Piotr Bogacz : 674c589881860968007217625272c9305af1c6e6
Files :

  • application/src/main/webapp/pages/application/group/jsp/creategroup.jsp

  • application/src/main/java/org/mifos/customers/group/struts/actionforms/GroupCustActionForm.java

Jakub Slawinski : 9820abf8f247f5dcd5bf64b45ede002920d860d2
Files :

  • application/src/main/webapp/pages/application/group/jsp/creategroup.jsp

  • application/src/main/java/org/mifos/customers/group/struts/actionforms/GroupCustActionForm.java

Piotr Bogacz : 8baa91a4a9c70d3134f47439980ef2a059716e8a
Files :

  • application/src/main/webapp/pages/application/group/jsp/creategroup.jsp

  • application/src/main/java/org/mifos/customers/group/struts/actionforms/GroupCustActionForm.java

  • application/src/test/java/org/mifos/customers/group/struts/action/GroupActionStrutsTest.java

Piotr Bogacz : c0e07089dd92d094f2d6683b017cd0811831798b
Files :

  • application/src/main/webapp/WEB-INF/struts-config.xml

  • application/src/main/java/org/mifos/customers/group/struts/actionforms/GroupCustActionForm.java

  • application/src/main/java/org/mifos/customers/group/struts/action/GroupCustAction.java

  • appdomain/src/main/java/org/mifos/application/util/helpers/Methods.java

  • application/src/main/webapp/pages/application/group/jsp/creategroup.jsp

Mifos Hudson Jira Plugin User
February 17, 2011, 10:54 PM

Integrated in

head-master-commit #4

Revert "MIFOS-3498"

Piotr Bogacz : 674c589881860968007217625272c9305af1c6e6
Files :

  • application/src/main/webapp/pages/application/group/jsp/creategroup.jsp

  • application/src/main/java/org/mifos/customers/group/struts/actionforms/GroupCustActionForm.java

Jakub Slawinski : 9820abf8f247f5dcd5bf64b45ede002920d860d2
Files :

  • application/src/main/java/org/mifos/customers/group/struts/actionforms/GroupCustActionForm.java

  • application/src/main/webapp/pages/application/group/jsp/creategroup.jsp

Piotr Bogacz : 8baa91a4a9c70d3134f47439980ef2a059716e8a
Files :

  • application/src/main/webapp/pages/application/group/jsp/creategroup.jsp

  • application/src/test/java/org/mifos/customers/group/struts/action/GroupActionStrutsTest.java

  • application/src/main/java/org/mifos/customers/group/struts/actionforms/GroupCustActionForm.java

Piotr Bogacz : c0e07089dd92d094f2d6683b017cd0811831798b
Files :

  • appdomain/src/main/java/org/mifos/application/util/helpers/Methods.java

  • application/src/main/webapp/pages/application/group/jsp/creategroup.jsp

  • application/src/main/java/org/mifos/customers/group/struts/action/GroupCustAction.java

  • application/src/main/java/org/mifos/customers/group/struts/actionforms/GroupCustActionForm.java

  • application/src/main/webapp/WEB-INF/struts-config.xml

Mifos Hudson Jira Plugin User
February 18, 2011, 6:51 AM

Integrated in

acceptanceTestsImprovements #5

Revert "MIFOS-3498"

Piotr Bogacz : 674c589881860968007217625272c9305af1c6e6
Files :

  • application/src/main/webapp/pages/application/group/jsp/creategroup.jsp

  • application/src/main/java/org/mifos/customers/group/struts/actionforms/GroupCustActionForm.java

Jakub Slawinski : 9820abf8f247f5dcd5bf64b45ede002920d860d2
Files :

  • application/src/main/webapp/pages/application/group/jsp/creategroup.jsp

  • application/src/main/java/org/mifos/customers/group/struts/actionforms/GroupCustActionForm.java

Piotr Bogacz : 8baa91a4a9c70d3134f47439980ef2a059716e8a
Files :

  • application/src/test/java/org/mifos/customers/group/struts/action/GroupActionStrutsTest.java

  • application/src/main/webapp/pages/application/group/jsp/creategroup.jsp

  • application/src/main/java/org/mifos/customers/group/struts/actionforms/GroupCustActionForm.java

Piotr Bogacz : c0e07089dd92d094f2d6683b017cd0811831798b
Files :

  • application/src/main/webapp/pages/application/group/jsp/creategroup.jsp

  • application/src/main/java/org/mifos/customers/group/struts/actionforms/GroupCustActionForm.java

  • application/src/main/webapp/WEB-INF/struts-config.xml

  • application/src/main/java/org/mifos/customers/group/struts/action/GroupCustAction.java

  • appdomain/src/main/java/org/mifos/application/util/helpers/Methods.java

Fixed

Assignee

Piotr Bogacz

Reporter

Ryan Whitney

Labels

URL

None

Story Points

0

Team

Community

Scheduled For

Product

Epic

None

Notify

None

productboard URL

None

Man Day Estimate

None

Components

Fix versions

Affects versions

Priority

Minor
Configure