UserContext.userGlobalNo does not get populated

Description

PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

Environment

None

Activity

Show:
Mifos Hudson Jira Plugin User
October 6, 2011, 5:34 PM

Integrated in

head-master-secondary #512
MIFOS-3610: remove globalUserNo field from UserContext as it not used anywhere.

Keith Woodlock :
Files :

  • abstract-domain/src/main/java/org/mifos/security/util/UserContext.java

Lukasz Chudy
October 7, 2011, 9:12 AM

Keith,

You've marked this issue as invalid but what about the Ferenc question?

keithwoodlock
October 7, 2011, 9:38 AM

Lukasz, Ferenc,

As far as I can see, the userContext was never populated with the user global no. So I marked the issue as invalid as if ferenc or any other developer wanted access to the user global no they could get that off the PersonnelBO entity itself (infact its DTO equivalent) rather than translating it into another location (UserContext).

Added to this, the UserContext is passed back to .jsp pages but it is not the strategy with .ftl pages. Instead other DTO objects are passed back and the objective going forward was to remove all .jsp pages and release the lock they have on domain objects.

Ferenc Kovács
October 7, 2011, 10:47 AM

Hi Keith!

Thank you for your thorough answer. If I understand you correctly, we can expect the whole UserContext story going to deprecated with the elimination of .jsp pages? So from now on, the "pure" DTO-s are to be used all over the client layer?

Best regards,
Ferenc

keithwoodlock
October 7, 2011, 11:00 AM

Ferenc, that was the plan at least but nothing has happened in this direction (re-implementation of UI using DTOs rather than domain bojects) since end of June 2011.

There are a number of problems with JSP implementation of presentation and Whilst I dont know about DTO 'pure'-ness, it was the mechanism used to get around problems of passing domain entities back to presentation and the future goal of mifos to be an open 'platform' with a clear set of exposed services.

Assignee

Lukasz Chudy

Reporter

Ferenc Kovács

Labels

None

URL

None

Story Points

0

Team

Community

Scheduled For

Release

Epic

None

Notify

None

productboard URL

None

Man Day Estimate

None

Time tracking

0m

Time remaining

15m

Components

Fix versions

Affects versions

Priority

Trivial
Configure