Adjustments are incorrect in Tally GL Interface Report

Description

Turns out we need to go back to Plan A.

Adjustments do need to be the opposite voucher type of the original transaction it was adjusting.

For example, if an adjustment is made on a loan repayment - the original transaction is logged as RECEIPT, but the adjustment needs to roll up to PAYMENT.

If an adjustment is made on a disbursal, the original transaction is a PAYMENT, but the adjustment needs to roll up to a RECEIPT.

Environment

None

Activity

Show:
johnwoodlock
September 15, 2010, 1:35 AM

There was a need to break down certain financial actions into which account actions they were related to in order to identify the right voucher. Below is a representation of this change.

(CASE fintrxn.fin_action_id
WHEN 1, 2, 4, 6 then /PRINCIPALPOSTING, INTERESTPOSTING, MISCFEEPOSTING, MISCPENALTYPOSTING/
(CASE atrxn.account_action_id
WHEN 1 then 'RECEIPT' /LoanRepayment/
WHEN 9 then 'JOURNAL' /Adjustment (undoes LoanRepayment)/
WHEN 18 then 'JOURNAL' /LoanReversal (reverses fees & payments parts)/
ELSE concat('Unknown Account Action:', atrxn.account_action_id, ' for Finanical Action ', fintrxn.fin_action_id)
END)
WHEN 3 then /FEEPOSTING/
(CASE atrxn.account_action_id
WHEN 4 then 'RECEIPT' /Fee/
WHEN 18 then 'JOURNAL' /LoanReversal (reverses fees & payments parts)/
WHEN 12 then 'RECEIPT' /Customer Fee/
WHEN 13 THEN 'JOURNAL' /CustomerAdjustment/
ELSE concat('Unknown Account Action:', atrxn.account_action_id, ' for Finanical Action ', fintrxn.fin_action_id)
END)
WHEN 7 then /DISBURSAL/
(CASE atrxn.account_action_id
WHEN 10 then 'PAYMENT' /Disbursal/
WHEN 19 then 'JOURNAL' /DisrbursalAmountReversal (undoes Disbursal part)/

  • Hide quoted text -
    ELSE concat('Unknown Account Action:', atrxn.account_action_id, ' for Finanical Action ', fintrxn.fin_action_id)
    END)

Further testing identified a couple of places where this logic needed to be extended.

"there were 2 missing mappings (this is where I hadn't anticipated the relationship between financial and account actions)

1) 'Loan Processing Fee' & 'Early Repayment Penalty Fee'. These are financial action '3' (fee) and are associated with an account action of 1 (loan repayment). I didn't have this mapping.

2) 'Miscellaneous Penalty' - this was financial action 6 (miscpenalty) , account action 12 (CustomerAccountRepayment)

So I put these in, all as RECEIPT vouchers, is that ok or are there journals amongst them ? I've update git and tested again on mifos_lightmf and all seems good now.

The positive thing about this is that if there are any more missing mappings they do appear as 'unknown' and can be rectified pretty quickly."

Assignee

johnwoodlock

Reporter

Kay Chau

Labels

None

URL

None

Story Points

0.5

Team

Core

Scheduled For

Product

Epic

Notify

None

productboard URL

None

Man Day Estimate

None

Components

Fix versions

Priority

Critical
Configure