Additional fields that don't migrate still show up on create workflows

Description

Data migration for E release migrates additional fields. But when additional field migration fails (e.g. duplicate titles) the custom field definitions stay in the old location for the database (as expected).

Since these custom fields are not migrated, the forms for creating client, system user, center, group, office, loans, and savings all still display custom fields along with any newly migrated question groups. This means users could enter data in old fields, whereas we want users to enter in question group tables only going forward. Old tables should only be used view only viewing unmigrated.

Please remove the old custom fields from the create path of client, system user, center, group, office, loans, and savings.

For testing, the 1.6.x test instance is one example of additional fields migration that fails - see http://mifosforge.jira.com/wiki/display/MIFOS/Data+Migration+test+progress.

Environment

None

Activity

Show:
Mifos Hudson Jira Plugin User
December 16, 2010, 12:54 PM

Integrated in

head-e-release #371
FIXED MIFOS-4337: Cleared custom fields on the Action/ActionForm/Service/ServiceFacade level.

Jakub Slawinski : be5b6321393f68a0e4924ac26988e155361accee
Files :

  • application/src/test/java/org/mifos/customers/office/struts/action/OfficeActionStrutsTest.java

  • application/src/main/java/org/mifos/customers/client/struts/actionforms/ClientCustActionForm.java

  • application/src/main/java/org/mifos/customers/center/struts/actionforms/CenterCustActionForm.java

  • application/src/main/java/org/mifos/customers/client/struts/action/ClientCustAction.java

  • application/src/main/java/org/mifos/customers/business/service/CustomerServiceImpl.java

  • application/src/main/java/org/mifos/customers/group/struts/action/GroupCustAction.java

  • application/src/test/java/org/mifos/customers/personnel/struts/action/PersonActionStrutsTest.java

  • application/src/main/java/org/mifos/customers/personnel/struts/action/PersonAction.java

  • application/src/test/java/org/mifos/customers/CenterCreationTest.java

  • application/src/main/java/org/mifos/customers/struts/actionforms/CustomerActionForm.java

  • application/src/main/java/org/mifos/accounts/savings/struts/action/SavingsAction.java

  • application/src/main/java/org/mifos/customers/personnel/struts/actionforms/PersonActionForm.java

  • application/src/test/java/org/mifos/customers/CenterUpdateTest.java

  • application/src/main/java/org/mifos/accounts/loan/struts/action/LoanAccountAction.java

  • application/src/main/java/org/mifos/customers/office/struts/actionforms/OffActionForm.java

  • application/src/test/java/org/mifos/accounts/savings/struts/action/SavingsActionStrutsTest.java

  • application/src/main/java/org/mifos/customers/center/struts/action/CenterCustAction.java

  • application/src/main/java/org/mifos/accounts/struts/action/AccountAppAction.java

  • application/src/main/java/org/mifos/customers/group/struts/actionforms/GroupCustActionForm.java

  • application/src/main/java/org/mifos/application/servicefacade/CustomerServiceFacadeWebTier.java

  • application/src/main/java/org/mifos/customers/office/struts/action/OffAction.java

  • application/src/test/java/org/mifos/customers/ClientCreationTest.java

  • application/src/main/java/org/mifos/application/servicefacade/PersonnelServiceFacadeWebTier.java

  • application/src/test/java/org/mifos/customers/ClientUpdateTest.java

  • application/src/main/java/org/mifos/accounts/loan/struts/actionforms/LoanAccountActionForm.java

  • application/src/main/java/org/mifos/accounts/savings/struts/actionforms/SavingsActionForm.java

Jakub Sławiński
December 16, 2010, 1:25 PM

Resolved in commit be5b6321393f68a0e4924ac26988e155361accee.

I performed the following tests before pushing this change to repository:
I created all types of mandatory additional fields and tested view/edit/create of the office/personnel/client/group/center/loan/savings.

Lukasz Chudy
December 16, 2010, 3:28 PM
Edited

Verified on 16.12.2010
Now Additional fields are not visible on create/edit flows for the Office/Personnel/Client/Group/Center/Loan/Savings.

Commit: be5b6321393f68a0e4924ac26988e155361accee
Build Number: hudson-head-e-release-371

Mifos Hudson Jira Plugin User
December 16, 2010, 4:49 PM

Integrated in

head-e-release #374
MIFOS-4337: remove references to custom fields in client BO and other locations which were mostly defensive changes.

Keith Woodlock : c2129607efebe9c065a7cb29fa2685dc363cb4b6
Files :

  • application/src/main/java/org/mifos/application/servicefacade/PersonnelServiceFacadeWebTier.java

  • application/src/main/java/org/mifos/customers/office/business/service/OfficeServiceFacadeWebTier.java

  • application/src/main/java/org/mifos/accounts/savings/struts/action/SavingsAction.java

  • application/src/test/java/org/mifos/accounts/savings/persistence/SavingsPersistenceIntegrationTest.java

  • application/src/main/java/org/mifos/customers/center/persistence/CenterPersistence.java

  • application/src/test/java/org/mifos/accounts/savings/struts/action/SavingsActionStrutsTest.java

  • application/src/main/java/org/mifos/customers/business/service/CustomerServiceImpl.java

  • application/src/main/java/org/mifos/customers/center/business/service/WebTierCenterDetailsServiceFacade.java

  • application/src/main/java/org/mifos/accounts/struts/action/AccountAppAction.java

  • application/src/main/java/org/mifos/customers/client/business/service/WebTierClientDetailsServiceFacade.java

  • application/src/main/java/org/mifos/customers/client/business/ClientBO.java

  • application/src/test/java/org/mifos/accounts/savings/persistence/SavingsBusinessServiceIntegrationTest.java

  • application/src/main/java/org/mifos/application/servicefacade/LoanServiceFacadeWebTier.java

  • application/src/main/java/org/mifos/accounts/savings/business/service/SavingsBusinessService.java

  • application/src/main/java/org/mifos/customers/group/business/service/WebTierGroupDetailsServiceFacade.java

  • application/src/main/java/org/mifos/accounts/savings/persistence/SavingsPersistence.java

Assignee

Jakub Sławiński

Reporter

Jeff Brewster

Labels

None

URL

None

Story Points

1

Team

Core

Scheduled For

Release

Epic

Notify

None

productboard URL

None

Man Day Estimate

None

Components

Affects versions

Priority

Major
Configure