Data Migration API: add flexibility group creation API to allow for setting any customer activation date

Description

When creating groups at present, the customer activiation date and mfi joining date are hard coded within the group creation logic of the domain entity to be 'todays' date.

Refactor this backup to outer layers and allow mfiJoiningDate and customer activation date to be injected allowing for greater flexibility.

Environment

None

Activity

Show:
keithwoodlock
February 1, 2011, 3:27 PM

added integration test to verify it was possible to create group with activation date in past.

Mifos Hudson Jira Plugin User
February 2, 2011, 6:25 PM

Integrated in

head-master #2805
MIFOS-4507: add integration test around group creation api
MIFOS-4507: add integration test around group creation api
MIFOS-4507: add integration test to verify api is capable of creating group with activation date in past

Keith Woodlock : 930b43c58625f4e2f3834e7bdff4ea468bdac686
Files :

  • application/src/test/java/org/mifos/framework/util/helpers/IntegrationTestObjectMother.java

  • appdomain/src/main/java/org/mifos/config/ClientRules.java

  • appdomain/src/main/java/org/mifos/application/servicefacade/GroupServiceFacadeWebTier.java

Keith Woodlock : dddcdbb2f89dccc4dafb311e87726d87ebc8df41
Files :

  • application/src/test/java/org/mifos/application/servicefacade/GroupServiceFacadeWebTierIntegrationTest.java

Keith Woodlock : 29c58fcacffb9784e9d188ee2b72cd6148cd7229
Files :

  • application/src/test/java/org/mifos/application/servicefacade/GroupServiceFacadeWebTierIntegrationTest.java

Jeff Brewster
February 3, 2011, 12:16 AM

verified current date still default on web UI date as called out above. Integration test in place as well.

Mifos Hudson Jira Plugin User
February 6, 2011, 5:52 PM

Integrated in

head-f-release #33
MIFOS-4507: add integration test around group creation api
MIFOS-4507: add integration test around group creation api
MIFOS-4507: add integration test to verify api is capable of creating group with activation date in past

Jakub Sławiński : 34adde77e7413b5ee4bf039fed1d9112a678faa9
Files :

  • application/src/test/java/org/mifos/framework/util/helpers/IntegrationTestObjectMother.java

  • appdomain/src/main/java/org/mifos/application/servicefacade/GroupServiceFacadeWebTier.java

  • appdomain/src/main/java/org/mifos/config/ClientRules.java

Jakub Sławiński : 8dfc3ee112adbba8f317f5a89ffa3c92e961544e
Files :

  • application/src/test/java/org/mifos/application/servicefacade/GroupServiceFacadeWebTierIntegrationTest.java

Jakub Sławiński : baf177db9d934b920f2108cba16ff9a63681caac
Files :

  • application/src/test/java/org/mifos/application/servicefacade/GroupServiceFacadeWebTierIntegrationTest.java

Mifos Hudson Jira Plugin User
February 6, 2011, 8:20 PM

Integrated in

head-master #2841
MIFOS-4507: add integration test around group creation api
MIFOS-4507: add integration test around group creation api
MIFOS-4507: add integration test to verify api is capable of creating group with activation date in past

Jakub Sławiński : 34adde77e7413b5ee4bf039fed1d9112a678faa9
Files :

  • appdomain/src/main/java/org/mifos/application/servicefacade/GroupServiceFacadeWebTier.java

  • appdomain/src/main/java/org/mifos/config/ClientRules.java

  • application/src/test/java/org/mifos/framework/util/helpers/IntegrationTestObjectMother.java

Jakub Sławiński : 8dfc3ee112adbba8f317f5a89ffa3c92e961544e
Files :

  • application/src/test/java/org/mifos/application/servicefacade/GroupServiceFacadeWebTierIntegrationTest.java

Jakub Sławiński : baf177db9d934b920f2108cba16ff9a63681caac
Files :

  • application/src/test/java/org/mifos/application/servicefacade/GroupServiceFacadeWebTierIntegrationTest.java

Fixed

Assignee

mifosqa

Reporter

keithwoodlock

Labels

None

Implementation Priority

None

URL

None

Story Points

0.5

Team

Core

Scheduled For

Release

Epic

None

productboard URL

None

Man Day Estimate

None

Components

Fix versions

Affects versions

Priority

Minor
Configure