View additional information showing extra questions not associated with specific loan product.

Description

I created a loan account that has one question group associated to Create Group and noticed that when viewing the question group responses an additional question group that isn't associated with the loan product is shown on the 'View Additional Information" page.

Repro steps:
1. Login to http://ci.mifos.org:8120/mifos
2. Search for account #000100000000006 which is a account for loan product "ClientLoanA"
3. click View Additional Information link
4. notice two sets of question/answers.
5. The second set of questions have no answers, since this group was (properly) not presented to the user during loan creation.

Expected:
To only see the questions and answers for "client business information" QG which is the only QG associated for the loan product.

Actual:
see questions for both question groups that associated to Create Loan - "client business information" and "indiv_fin_analysis"

Environment

None

Activity

Show:
Mifos Hudson Jira Plugin User
March 15, 2011, 4:58 PM

Integrated in

head-master-secondary #149
Bugfix

Vinod :
Files :

  • application/src/main/java/org/mifos/accounts/loan/struts/action/Criteria.java

  • appdomain/src/main/java/org/mifos/security/util/ActivityMapper.java

  • application/src/main/resources/META-INF/resources/WEB-INF/accounts-struts-config.xml

  • application/src/main/java/org/mifos/application/questionnaire/struts/QuestionnaireFlowAdapter.java

  • appdomain/src/main/java/org/mifos/application/util/helpers/ActionForwards.java

  • application/src/main/resources/META-INF/resources/pages/application/loan/jsp/loanaccountdetail.jsp

  • application/src/test/java/org/mifos/accounts/loan/struts/action/QuestionGroupFilterForLoanTest.java

  • application/src/main/java/org/mifos/application/questionnaire/struts/QuestionGroupFilter.java

  • appdomain/src/main/java/org/mifos/accounts/loan/util/helpers/LoanConstants.java

  • questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/flows/viewAndEditQuestionnaire.xml

  • application/src/main/java/org/mifos/accounts/loan/struts/action/QuestionGroupFilterForLoan.java

  • application/src/main/java/org/mifos/accounts/loan/struts/action/LoanAccountAction.java

Jeff Brewster
March 15, 2011, 7:40 PM

This appears fixed to me in hudson-head-master-archive-156. Not marking as verified since the issue is still in "Development In Progress" status.

Lukasz Chudy
March 17, 2011, 9:25 AM

Verified on 17.03.2011
Bug has been fixed properly. Now, 'View additional information' page for Loan account is showing only question groups which are associated only to 'Create Loan' flow.

Commit Identifier: 07e0b4dac846325f18ba34f4607166bd2e6189c6
Build Number: hudson-head-master-archive-162

Kay Chau
March 25, 2011, 6:33 PM

This is fixed but I see some questionable behavior with QG's associated with loan products when the flows they are attached to change, will open a new issue for this

Mifos Hudson Jira Plugin User
April 14, 2011, 7:45 PM

Integrated in

head-master #2920
Bugfix

Vinod : dec346aa8690be7feecc2ffe954588c4ce27d73b
Files :

  • questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/flows/viewAndEditQuestionnaire.xml

  • application/src/main/java/org/mifos/application/questionnaire/struts/QuestionGroupFilter.java

  • application/src/main/java/org/mifos/accounts/loan/struts/action/Criteria.java

  • application/src/test/java/org/mifos/accounts/loan/struts/action/QuestionGroupFilterForLoanTest.java

  • application/src/main/resources/META-INF/resources/pages/application/loan/jsp/loanaccountdetail.jsp

  • appdomain/src/main/java/org/mifos/security/util/ActivityMapper.java

  • application/src/main/java/org/mifos/accounts/loan/struts/action/QuestionGroupFilterForLoan.java

  • appdomain/src/main/java/org/mifos/accounts/loan/util/helpers/LoanConstants.java

  • appdomain/src/main/java/org/mifos/application/util/helpers/ActionForwards.java

  • application/src/main/java/org/mifos/accounts/loan/struts/action/LoanAccountAction.java

  • application/src/main/resources/META-INF/resources/WEB-INF/accounts-struts-config.xml

  • application/src/main/java/org/mifos/application/questionnaire/struts/QuestionnaireFlowAdapter.java

Assignee

Vinod John

Reporter

Jeff Brewster

Labels

None

URL

None

Story Points

None

Team

Community - Thoughtworks

Scheduled For

None

Epic

None

Notify

None

productboard URL

None

Man Day Estimate

None

Components

Fix versions

Affects versions

Priority

Minor
Configure