Inappropriate validation messages for mandatory fields during create Client flow

Description

If you mark the following fields as mandatory (on 'Define mandatory/hidden fields' page):

  • Ethnicity

  • Marital Status

  • Citizenship

then during create Client flow, an incorrect validation messages appear: "Please specify value for Caste." and "Please specify value for Client.MaritalStatus." and "Please specify value for Religion." when you leave above fields empty/without selection.

Environment

None

Activity

Show:
Kay Chau
March 8, 2011, 9:19 PM

Fix when we do UI conversion

Mifos Hudson Jira Plugin User
December 19, 2011, 3:38 PM

Integrated in

head-g-release-secondary #286
FIXED MIFOS-4827: corrected words in files, added necessary lines in files, created acceptance test

Jakub Slawinski :
Files :

  • application/src/test/java/org/mifos/customers/business/MasterDataRetrievalForCustomersIntegrationTest.java

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_hu.properties

  • acceptanceTests/src/test/resources/dataSets/LoanProcessWithDifferentCurrencyTest_001_dbunit.xml

  • application/src/main/resources/META-INF/resources/pages/application/configuration/jsp/definelookupoptions.jsp

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_de.properties

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_de.properties

  • appdomain/src/main/java/org/mifos/customers/persistence/CustomerDaoHibernate.java

  • application/src/main/resources/META-INF/resources/pages/application/client/jsp/edit_ClientPersonalInfo.jsp

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_km.properties

  • serviceInterfaces/src/main/java/org/mifos/dto/screen/ClientPersonalDetailDto.java

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources.properties

  • acceptanceTests/src/test/resources/dataSets/SavingsDeposit_001_result_dbunit.xml

  • acceptanceTests/src/test/resources/dataSets/acceptance_small_001_dbunit.xml

  • appdomain/src/main/java/org/mifos/customers/client/util/helpers/ClientConstants.java

  • acceptanceTests/src/test/resources/dataSets/mpesa_export_dbunit.xml

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_km.properties

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_mk.properties

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources.properties

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_zh_CN.properties

  • db/src/main/resources/changesets/changelog-Release_G.xml

  • appdomain/src/main/java/org/mifos/customers/client/business/ClientDetailEntity.java

  • appdomain/src/main/resources/org/mifos/config/localizedResources/ColumnMappingBundle.properties

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_pt.properties

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_te.properties

  • appdomain/src/main/java/org/mifos/config/util/helpers/HiddenMandatoryFieldNamesConstants.java

  • application/src/main/resources/org/mifos/framework/util/resources/audit/ColumnMapping.xml

  • appdomain/src/main/java/org/mifos/customers/persistence/CustomerDao.java

  • appdomain/src/main/java/org/mifos/application/master/util/helpers/MasterConstants.java

  • acceptanceTests/src/test/resources/dataSets/REST_API_20110912_dbunit.xml

  • application/src/main/resources/META-INF/resources/pages/application/client/jsp/create_ClientPersonalInfo.jsp

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_fr.properties

  • appdomain/src/main/java/org/mifos/application/servicefacade/AdminServiceFacadeWebTier.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/framework/client/CreateClientEnterPersonalDataPage.java

  • acceptanceTests/src/test/resources/dataSets/acceptance_dbunit.xml

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_zh_CN.properties

  • application/src/main/java/org/mifos/framework/util/helpers/LabelTagUtils.java

  • serviceInterfaces/src/main/java/org/mifos/dto/screen/ClientDropdownsDto.java

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_te.properties

  • appdomain/src/main/java/org/mifos/config/util/helpers/ConfigurationConstants.java

  • appdomain/src/main/resources/org/mifos/customers/client/business/ClientDetailEntity.hbm.xml

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_es.properties

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_fr.properties

  • acceptanceTests/src/test/resources/dataSets/acceptance_small_008_dbunit.xml

  • acceptanceTests/src/test/resources/dataSets/acceptance_small_002_dbunit.xml

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/admin/DefineHiddenMandatoryFieldsTest.java

  • application/src/main/resources/META-INF/resources/pages/application/client/jsp/viewClientDetails.jsp

  • application/src/main/java/org/mifos/customers/client/struts/action/ClientCustAction.java

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_nl.properties

  • application/src/main/resources/META-INF/resources/pages/application/client/jsp/preview_ClientDetails.jsp

  • appdomain/src/main/java/org/mifos/customers/office/business/service/MandatoryHiddenFieldServiceImpl.java

  • appdomain/src/main/resources/org/mifos/customers/business/CustomerBO.hbm.xml

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_es.properties

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages.properties

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_zh_CN.properties

  • appdomain/src/main/java/org/mifos/application/servicefacade/ClientServiceFacadeWebTier.java

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_br.properties

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_km.properties

  • application/src/main/java/org/mifos/config/struts/action/LookupOptionsAction.java

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_tl.properties

  • application/src/test/java/org/mifos/customers/client/struts/action/ClientCustActionStrutsTest.java

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_hu.properties

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_pt.properties

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_nl.properties

  • application/src/test/java/org/mifos/domain/builders/ClientPersonalDetailDtoBuilder.java

  • acceptanceTests/src/test/resources/dataSets/acceptance_medium_005_dbunit.xml

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_hu.properties

  • application/src/test/java/org/mifos/config/struts/action/LookupOptionsActionStrutsTest.java

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_ca.properties

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/client/ClientTest.java

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_de.properties

  • application/src/main/resources/META-INF/resources/pages/application/client/jsp/preview_EditClientPersonalInfo.jsp

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_fr.properties

  • acceptanceTests/src/test/resources/dataSets/ColSheetCustAcct_001_result_dbunit.xml

  • acceptanceTests/src/test/resources/dataSets/acceptance_small_003_dbunit.xml

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_nl.properties

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_pt.properties

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_te.properties

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_es.properties

Łukasz Lewczyński
December 19, 2011, 4:01 PM

Fixed in commit 079fa08e922ae7896f705e0d640b772829bc8e92

Lukasz Chudy
December 20, 2011, 8:13 AM

Verified on 20.12.2011
Bug has been fixed properly.

Mifos Hudson Jira Plugin User
December 23, 2011, 9:58 AM

Integrated in

head-master-secondary #578
FIXED MIFOS-4827: corrected words in files, added necessary lines in files, created acceptance test

Jakub Slawinski :
Files :

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_te.properties

  • acceptanceTests/src/test/resources/dataSets/REST_API_20110912_dbunit.xml

  • application/src/main/java/org/mifos/config/struts/action/LookupOptionsAction.java

  • appdomain/src/main/java/org/mifos/application/servicefacade/ClientServiceFacadeWebTier.java

  • appdomain/src/main/java/org/mifos/customers/office/business/service/MandatoryHiddenFieldServiceImpl.java

  • appdomain/src/main/java/org/mifos/customers/persistence/CustomerDaoHibernate.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/framework/client/CreateClientEnterPersonalDataPage.java

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_nl.properties

  • acceptanceTests/src/test/resources/dataSets/acceptance_small_001_dbunit.xml

  • acceptanceTests/src/test/resources/dataSets/acceptance_small_002_dbunit.xml

  • appdomain/src/main/resources/org/mifos/customers/business/CustomerBO.hbm.xml

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources.properties

  • db/src/main/resources/changesets/changelog-Release_G.xml

  • appdomain/src/main/resources/org/mifos/customers/client/business/ClientDetailEntity.hbm.xml

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_hu.properties

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_zh_CN.properties

  • application/src/test/java/org/mifos/customers/client/struts/action/ClientCustActionStrutsTest.java

  • acceptanceTests/src/test/resources/dataSets/ColSheetCustAcct_001_result_dbunit.xml

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_pt.properties

  • acceptanceTests/src/test/resources/dataSets/acceptance_dbunit.xml

  • application/src/main/resources/META-INF/resources/pages/application/client/jsp/create_ClientPersonalInfo.jsp

  • application/src/main/java/org/mifos/framework/util/helpers/LabelTagUtils.java

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_tl.properties

  • application/src/main/resources/META-INF/resources/pages/application/client/jsp/viewClientDetails.jsp

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources.properties

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_mk.properties

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_es.properties

  • application/src/main/resources/META-INF/resources/pages/application/configuration/jsp/definelookupoptions.jsp

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_es.properties

  • acceptanceTests/src/test/resources/dataSets/mpesa_export_dbunit.xml

  • acceptanceTests/src/test/resources/dataSets/acceptance_medium_005_dbunit.xml

  • acceptanceTests/src/test/resources/dataSets/acceptance_small_008_dbunit.xml

  • appdomain/src/main/java/org/mifos/customers/client/util/helpers/ClientConstants.java

  • acceptanceTests/src/test/resources/dataSets/SavingsDeposit_001_result_dbunit.xml

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_km.properties

  • application/src/main/resources/META-INF/resources/pages/application/client/jsp/preview_ClientDetails.jsp

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_ca.properties

  • acceptanceTests/src/test/resources/dataSets/acceptance_small_003_dbunit.xml

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_fr.properties

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/admin/DefineHiddenMandatoryFieldsTest.java

  • appdomain/src/main/java/org/mifos/application/master/util/helpers/MasterConstants.java

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages.properties

  • application/src/main/resources/org/mifos/framework/util/resources/audit/ColumnMapping.xml

  • appdomain/src/main/java/org/mifos/config/util/helpers/ConfigurationConstants.java

  • application/src/main/resources/META-INF/resources/pages/application/client/jsp/preview_EditClientPersonalInfo.jsp

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_te.properties

  • application/src/test/java/org/mifos/config/struts/action/LookupOptionsActionStrutsTest.java

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_es.properties

  • appdomain/src/main/java/org/mifos/application/servicefacade/AdminServiceFacadeWebTier.java

  • appdomain/src/main/java/org/mifos/config/util/helpers/HiddenMandatoryFieldNamesConstants.java

  • application/src/main/resources/META-INF/resources/pages/application/client/jsp/edit_ClientPersonalInfo.jsp

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_km.properties

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_de.properties

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_pt.properties

  • application/src/test/java/org/mifos/customers/business/MasterDataRetrievalForCustomersIntegrationTest.java

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_br.properties

  • appdomain/src/main/java/org/mifos/customers/persistence/CustomerDao.java

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_nl.properties

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_de.properties

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_pt.properties

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_fr.properties

  • serviceInterfaces/src/main/java/org/mifos/dto/screen/ClientDropdownsDto.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/client/ClientTest.java

  • appdomain/src/main/resources/org/mifos/config/localizedResources/ColumnMappingBundle.properties

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_hu.properties

  • application/src/main/resources/org/mifos/config/localizedResources/MessageLookupMessages_zh_CN.properties

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_zh_CN.properties

  • serviceInterfaces/src/main/java/org/mifos/dto/screen/ClientPersonalDetailDto.java

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_km.properties

  • acceptanceTests/src/test/resources/dataSets/LoanProcessWithDifferentCurrencyTest_001_dbunit.xml

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_hu.properties

  • application/src/test/java/org/mifos/domain/builders/ClientPersonalDetailDtoBuilder.java

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_te.properties

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_fr.properties

  • appdomain/src/main/java/org/mifos/customers/client/business/ClientDetailEntity.java

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources_nl.properties

  • application/src/main/resources/org/mifos/config/localizedResources/FieldUIResources_de.properties

  • application/src/main/java/org/mifos/customers/client/struts/action/ClientCustAction.java

Assignee

Łukasz Lewczyński

Reporter

Lukasz Chudy

Labels

URL

None

Story Points

0

Team

Core

Scheduled For

None

Epic

None

Notify

None

productboard URL

None

Man Day Estimate

None

Components

Fix versions

Affects versions

Priority

Minor
Configure