Incorrect error message while trying to move Client with 'On Hold' status to Group in 'Pending Approval' status

Description

Repro:
1. Login with the user who has been assigned the right to add group membership. Search for an independent client with 'On Hold' status.
2. Click on a client name.
3. On the Client Information page, click on "Edit Meeting Schedule/Add Group".
4. Click on "click here to add group membership"
5. Specify the group name with "Pending Approval" status and click "Search".
6. Click on the group name.
7. Click "Submit".

Expected result:
The user should not able to move further and a message pops up. Message: 'Group status should be higher than that of Client'.

Actual result:
The following error message appears: '{0} status should be higher than that of {1}'.

Environment

None

Activity

Show:
Kay Chau
March 17, 2011, 8:56 PM

See if this is fixed as a result of new customized text implementation

Mifos Hudson Jira Plugin User
March 25, 2011, 8:35 PM

Integrated in

head-master-secondary #201
MIFOS-4858. Removed parameters from messages, using CustomizedText means these are no longer needed.

Van Mittal-Henkle :
Files :

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources.properties

  • appdomain/src/main/java/org/mifos/customers/client/business/ClientBO.java

  • application/src/main/resources/org/mifos/config/localizedResources/CustomerUIResources.properties

  • appdomain/src/main/java/org/mifos/customers/business/service/CustomerServiceImpl.java

Van Mittal-Henkle
March 25, 2011, 8:44 PM

Updated error messages and code to address the issue. On the 8085 test server, this issue can be observed by using the "onhold onhold" client and attempting to move it to the "Pending Approval Group".

Lukasz Chudy
March 28, 2011, 8:02 AM

Verified on 28.03.2011
Now, an appropriate error message appears - 'Group status should be higher than that of Client'.

Commit Identifier: bfe9fc9a8eeb739c8d462fe16aa7a5f7bf3f760e
Build Number: hudson-head-master-archive-200

Mifos Hudson Jira Plugin User
April 14, 2011, 7:45 PM

Integrated in

head-master #2920
MIFOS-4858. Removed parameters from messages, using CustomizedText means these are no longer needed.

Van Mittal-Henkle : bfe9fc9a8eeb739c8d462fe16aa7a5f7bf3f760e
Files :

  • application/src/main/resources/org/mifos/config/localizedResources/ClientUIResources.properties

  • application/src/main/resources/org/mifos/config/localizedResources/CustomerUIResources.properties

  • appdomain/src/main/java/org/mifos/customers/client/business/ClientBO.java

  • appdomain/src/main/java/org/mifos/customers/business/service/CustomerServiceImpl.java

Assignee

Van Mittal-Henkle

Reporter

Lukasz Chudy

Labels

None

URL

None

Story Points

None

Team

Core

Scheduled For

None

Epic

None

Notify

None

productboard URL

None

Man Day Estimate

None

Components

Fix versions

Affects versions

Priority

Minor
Configure