Test helpers need some cleanup

Description

The following test helpers need a little cleanup:

  • There are two OfficeHelper classes so one of them should be removed

  • LoanTestHelper contains methods that should belong to LoanProductTestHelper

  • FeeTestHelper and FeesHelper should be merged

Environment

None

Activity

Show:
Mifos Hudson Jira Plugin User
March 18, 2011, 4:25 PM

Integrated in

head-master-secondary #164

Piotr Bogacz :
Files :

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loanproduct/LoanProductTestHelper.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/framework/testhelpers/LoanTestHelper.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/CreateMultipleLoanAccountTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/framework/testhelpers/OfficeHelper.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/admin/OfficeHelper.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/ViewOriginalLoanScheduleTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/LoanAccountCycleTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/FeeTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/VariableInstalmentLoanTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loanproduct/VariableInstalmentLoanProductTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/CreateClientLoanAccountTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/admin/FeeTestHelper.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/admin/DefineAndViewFeesTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/LoanRepayTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/admin/DefineAndViewOfficeTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/admin/FeesHelper.java

Lukasz Chudy
March 21, 2011, 8:31 AM

Verified on 21.03.2011
Cleanup in test helpers has been done properly.

Mifos Hudson Jira Plugin User
April 14, 2011, 7:45 PM

Integrated in

head-master #2920

Piotr Bogacz : 993e6053f587c37e580d944537f849815ae4b39a
Files :

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/admin/DefineAndViewFeesTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/framework/testhelpers/OfficeHelper.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/LoanAccountCycleTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/FeeTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loanproduct/LoanProductTestHelper.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/admin/OfficeHelper.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/ViewOriginalLoanScheduleTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/admin/FeesHelper.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loanproduct/VariableInstalmentLoanProductTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/CreateClientLoanAccountTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/admin/FeeTestHelper.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/CreateMultipleLoanAccountTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/admin/DefineAndViewOfficeTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/framework/testhelpers/LoanTestHelper.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/LoanRepayTest.java

  • acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/VariableInstalmentLoanTest.java

Fixed

Assignee

Piotr Bogacz

Reporter

Lukasz Chudy

Labels

None

Implementation Priority

None

URL

None

Story Points

None

Team

Core

Scheduled For

None

Epic

None

productboard URL

None

Man Day Estimate

None

Fix versions

Affects versions

Priority

Minor