Changing meeting schedule of client updates their loan schedules too with LSIM on

Description

Steps to reproduce the problem :

  1. Select a client with monthly meeting dates and having at least one active loan

  2. Enter to the client page

  3. Click on "Edit meeting schedule / Add Group »

  4. Change the details of the meeting schedule : from Second Monday of every 1 month to Second Thursday of every 1 month then apply

  5. Check the loan schedule of the client

Expected behavior : no change in the loan schedule dates
Actual behavior in V2.1 : loan schedule dates will change accordingly to the change of the meetings day "Tuesday".
Actual behavior in V1.6 : loan schedule dates will not change till the run of the batch job
Exple:
Loan schedule dates before the change:
#1 13-Jun-2011
#2 11-Jul-2011
#3 08-Aug-2011
#4 12-Sep-2011

Loan schedule dates after the change:
#1 16-Jun-2011
#2 14-Jul-2011
#3 11-Aug-2011
#4 15-Sep-2011

Workaround
• mifos V1.6 : disable all batch jobs that regenerate schedule in the task.xml conf file
• mifos V2.1 remove permission to modify meeting schedule.

Additional information:
LSIM is enabled
Mifos version : V2.1

Environment

None

Activity

Show:
keithwoodlock
April 5, 2011, 2:28 PM

Kay,

So it looks like changing meeting schedule of customer hierarchy (center->group->client, group->client, client) with LSIM on causes loan schedules to also change. in older versions of mifos this occured with overnight batch job and more recently it is done 'inline' with the actual changing of the 'customer meeting schedule'. To stop loan schedules from being update also when LSIM is on, its as simple as check for the configuration and not allow 'changing of loan schedules' but do allow changing of customer_schedules.

Keith.

Kay Chau
April 5, 2011, 4:13 PM

Thanks Keith, and just wanted to add a comment here that Lukasz has confirmed this is happening on 2.1 as well.

Mifos Hudson Jira Plugin User
April 14, 2011, 2:32 PM

Integrated in

head-master-secondary #278
MIFOS-4933: tidy up

Keith Woodlock :
Files :

  • appdomain/src/main/java/org/mifos/customers/business/service/CustomerServiceImpl.java

Mifos Hudson Jira Plugin User
April 14, 2011, 7:45 PM

Integrated in

head-master #2920
MIFOS-4933: only update meeting schedule of loan accounts when customer meeting schedule changes if LSIM is turned off
MIFOS-4933: tidy up

Keith Woodlock : 45e5b0881f9dddc7ca7150bcf3252e044c05fc7a
Files :

  • appdomain/src/main/java/org/mifos/customers/business/service/MifosConfigurationHelper.java

  • appdomain/src/main/java/org/mifos/customers/business/service/DefaultMifosConfigurationHelper.java

  • application/src/test/java/org/mifos/customers/UpdateCustomerMeetingScheduleTest.java

  • application/src/test/java/org/mifos/domain/builders/CenterBuilder.java

  • appdomain/src/main/java/org/mifos/customers/business/service/CustomerServiceImpl.java

Keith Woodlock : 7da5b9683725f7e7e44de7cdcc23c09fd9d1eb14
Files :

  • appdomain/src/main/java/org/mifos/customers/business/service/CustomerServiceImpl.java

Lukasz Chudy
April 15, 2011, 10:02 AM

Verified on 15.04.2011
Bug has been fixed properly.

Assignee

mifosqa

Reporter

Kay Chau

Labels

URL

None

Story Points

None

Team

Core

Scheduled For

Release

Epic

None

Notify

None

productboard URL

None

Man Day Estimate

None

Components

Fix versions

Affects versions

Priority

Minor
Configure