db traffic increase in 2.1 release and head/master due to change in label cache

Description

Since Mifos version 2.1, database traffic has increased significantly. The cause seems to be related to a change in the code used to look up translatable strings.

Discussion: http://thread.gmane.org/gmane.comp.finance.mifos.devel/11522

Environment

None

Activity

Show:
Mifos Hudson Jira Plugin User
April 25, 2011, 6:27 PM

Integrated in

head-f-release #150
MIFOS-4949. Fix SERVICE_CHARGE lookup special case.

Van Mittal-Henkle : c77fa5e69569fd11c80c221ad6020b60f80f5de7
Files :

  • application/src/main/java/org/mifos/framework/util/helpers/LabelTagUtils.java

Van Mittal-Henkle
April 25, 2011, 9:10 PM

fixed in f-release and merged to head/master.

Replaced code that retrieved lookup values from the database with code that went through MessageLookup and used the legacy caching mechanism to avoid hitting the database.

In the g-release the whole lookup label customization mechanism is replaced by the CustomizedText mechanism, so this code should stop being used as usage of the MifosLabel custom tag is eliminated.

Mifos Hudson Jira Plugin User
April 25, 2011, 9:15 PM

Integrated in

head-f-release #151
MIFOS-4949. Removing dead code.

Van Mittal-Henkle : 4d9772379713691b9ce8e841c3435806fe1200c5
Files :

  • application/src/main/java/org/mifos/framework/util/helpers/LabelTagUtils.java

Mifos Hudson Jira Plugin User
April 25, 2011, 10:15 PM

Integrated in

head-master-secondary #306
replaced dto based lookup for labels with old lookup code
MIFOS-4949. Update to only replace text for label keys.
MIFOS-4949. Fix SERVICE_CHARGE lookup special case.
MIFOS-4949. Removing dead code.

Van Mittal-Henkle :
Files :

  • application/src/main/java/org/mifos/framework/util/helpers/LabelTagUtils.java

Van Mittal-Henkle :
Files :

  • application/src/main/java/org/mifos/framework/util/helpers/LabelTagUtils.java

Van Mittal-Henkle :
Files :

  • application/src/main/java/org/mifos/framework/util/helpers/LabelTagUtils.java

Van Mittal-Henkle :
Files :

  • application/src/main/java/org/mifos/framework/util/helpers/LabelTagUtils.java

Lukasz Chudy
April 29, 2011, 1:04 PM

Verified on 29.04.2011
According to the attached discussion, performance is now the same as in Mifos 2.0.

Assignee

Van Mittal-Henkle

Reporter

Adam Monsen

Labels

URL

None

Story Points

2

Team

Core

Scheduled For

Release

Epic

None

Notify

None

productboard URL

None

Man Day Estimate

None

Affects versions

Priority

Minor
Configure