Impossible to disable permissions for creating new Loan account, Savings account and Redo loan

Description

The following permissions are not working:

  • Can create new loan account in Save for later state

  • Can create new loan account in Submit for approval state

  • Can redo Loan disbursals

  • Can create new Savings account in Save for later state

After disabling above permissions it is still possible to create a new Loan account, Savings account or to Redo loan.

Environment

None

Activity

Show:
keithwoodlock
July 1, 2011, 12:06 PM

access is denied for creating loan or savings account or redoing loan if they dont have permissions.

NOTE: the difference between save for later and save for approval is not added in this fix. Another bug can be created for that but it will take a bit more work and may not be needed based on other issues around removing these capabilities.

Lukasz Chudy
July 1, 2011, 12:41 PM

Keith, 'Can create new Savings account in Save for later state' permission is still not working so it is still possible to create Savings account in Save for later state.

I will create new issue for the difference between 'save for later' and 'save for approval' in Loan creation flow.

I will also create another issue because it will be better to display 'Access denied' page just after clicking 'Redo Loan disbursal' link, rather than after clicking 'Search' button.

Mifos Hudson Jira Plugin User
July 1, 2011, 12:45 PM

Integrated in

head-g-release-secondary #113
MIFOS-5079: add permissions to create loan, redo loan and create savings account services.

Keith Woodlock :
Files :

  • serviceInterfaces/src/main/java/org/mifos/application/servicefacade/LoanAccountServiceFacade.java

  • appdomain/src/main/resources/org/mifos/security/rolesandpermission/mifos_activity_role.properties

  • serviceInterfaces/src/main/java/org/mifos/application/servicefacade/SavingsServiceFacade.java

Lukasz Chudy
July 1, 2011, 1:14 PM

Keith, it seems that it is not possible to disable permission to create new Savings account in Save for later state, after clicking 'Search' button because then it will be also not possible create new Savings account in Submit for approval state.

So I am resolving this issue as fixed and I will create new issue for disabling permission to create new Savings account in Save for later state.

Lukasz Chudy
July 1, 2011, 1:45 PM

I've created new Improvements for the issues mentioned above:

  • Display 'Access denied' page just after clicking 'Redo Loan disbursal' link rather than after clicking 'Search' button

  • Allow possibility to disable one of the permissions for creating new loan account (in 'Save for later' state or in 'Submit for approval' state)

  • Allow possibility to disable permission for creating new Savings account in 'Save for later' state

Assignee

mifosqa

Reporter

Lukasz Chudy

Labels

None

URL

None

Story Points

None

Team

Core

Scheduled For

Release

Epic

None

Notify

None

productboard URL

None

Man Day Estimate

None

Components

Fix versions

Affects versions

Priority

Critical
Configure