IntroductionContents::sectnum::
This document is intended to serve as a pre-`submit` submit checklist for patch contributors and a pre-`commit` commit checklist for committers. Contributions following these guidelines have a much better chance of being accepted into Mifos.
Excellent Patches
- take `less less than one hour` hour to look over and accept (not including build time)
- were created with "git format-patch" and apply cleanly using "git am"
- follow CodeSubmissionProcess, CodingStandards Code Submission Process, Coding Standards, and VettingPatches Vetting Patches
- are easy to understand because they are accompanied by explanation/justification or the issue description is clear
If you know a patch is not excellent, reject it (see next section on how to do this). If you're not sure, ask for help on IRC and/or the mifos-developer or mifos-users mailing lists.
If the patch doesn't apply cleanly but is very small, manually apply it if you can do so quickly/easily.
...
All files use licensing information as specified at MifosLicensing Mifos Licensing.
Language
Proper grammar, spelling, and punctuation is used.
...
Omit your own name. Ex: "this file created/mainted by me, Adam Monsen". Once the code is checked in, `we we all own it, any one of us may maintain it`it! Credit for contributors should appear in the AUTHORS file only.
...