...
Here are some things that we look for in patches we receive in order to decide if someone should get commit privileges and continue evaluating to determine is someone should retain commit privileges they have been granted. Contributors should:
- Follow the CodeSubmissionProcess Code Submission Process and not break the build
- Follow builds on our continuous integration server so that you are aware if the build has been broken (committers, also see HowToBreakTheBuild How To Break The Build)
- Write test driven code. If you are fixing a bug, then there should be a test which demonstrates the bug. If you are building new functionality, then there should be unit tests that exercise that functionality.
- Work iteratively. If you are working on something that involves a significant amount of code, send it in multiple patches or commits as you complete parts of the work rather than one big piece when everything is done.
- Not introduce new bugs. Fixing a bug or adding a feature shouldn't break other functionality.
- Follow the Mifos CodingStandards. Please make note of the Database Standards which require that Coding Standards. Database schema changes must be accompanied by appropriate automatic upgrade steps.
- Demonstrate the ability to write clean code and apply good software design
- Submit a contributor agreement
- Participate on the mifos-developer mailing list
- Read AddingSoftwareToMifos Adding Software To Mifos before introducing dependencies on new third party libraries
...